Icon is not Centered

Question

Icon is not Centered

Neodevils opened this issue 2 years ago · 7 comments

Neodevils commented 2 years ago

North Star icon is not centered.

Answer 1 · 2023-02-07T19:47:50.000Z

Hi! Thanks for opening the issue - I'll forward it to the Octicons Working Group project board.

Answer 2 · 2023-02-08T14:40:14.000Z

Hi! Thanks for opening the issue - I'll forward it to the Octicons Working Group project board.

Alright! Take your time. 👍🏻

Answer 3 · 2023-02-22T17:23:21.000Z

Is this misalignment causing an issue? I didn't create the icon but I'm guessing it was done this way so that the vertical and horizontal lines are properly aligned to the pixel grid. Directly centering it would cause all lines to be set on half or quarter pixels.

Answer 4 · 2023-02-22T17:34:33.000Z

Is this misalignment causing an issue? I didn't create the icon but I'm guessing it was done this way so that the vertical and horizontal lines are properly aligned to the pixel grid. Directly centering it would cause all lines to be set on half or quarter pixels.

Well, yes. Misalignment. Either the vector has to be a little bit longer or shorter then.

Answer 5 · 2023-02-23T06:28:07.000Z

I did some more tests with this icon in the UI and feel like the half pixel alignment on the vertical and horizontal lines is probably worth the trade off. I'll see about getting this change shipped in the next update.

Answer 6 · 2023-02-24T09:41:58.000Z

I did some more tests with this icon in the UI and feel like the half pixel alignment on the vertical and horizontal lines is probably worth the trade off. I'll see about getting this change shipped in the next update.

Thank you. I'll be watching this issue.

Answer 7 · 2023-05-09T17:14:16.000Z

Hi, thanks for bringing this up and thanks for the due diligence @gavinmn. I'm chiming in with some history on the creation of this icon, there was a specific reason that we decided to make it slightly off centered, so we will not be shifting it at this time.