primer/octicons

[Bug] The SVGs in /build/svg/ don't have the `octicon` classes attached

fregante opened this issue · 2 comments

Describe the bug

The classes:

Expected behavior

Could you include the octicon octicon-something classes in the built SVGs?

I only need this in @primer/octicons, but the issue also appears in @primer/octicons-react (however I don't understand the point of the built SVG files in that package since they're not allowed by the exports map)

Context

I want to import the raw SVGs in my extensions

So this is because the icons are plainly copied from the ./icons folder, which understandably doesn't have any extraneous attributes.

This issue doesn't affect me anymore though, I'm using https://github.com/fregante/octicons-plain-react