`DialogV2` has incorrect names for width values
Opened this issue · 1 comments
iansan5653 commented
The new Dialog
component has a width
prop:
react/packages/react/src/Dialog/Dialog.tsx
Lines 114 to 121 in f9eae58
These size names do not match the Primer overlay primitives.
It should be:
- xsmall: 192px
- small: 320px
- medium: 480px
- large: 640px
- xlarge: 960px
Currently the only way to make an actual xlarge
dialog is to set the width explicitly via sx
.
broccolinisoup commented
Thanks @iansan5653 for raising this issue. I liked it to the epic (Staff only link) that we do all the dialog work. Let us know if you have any concern with it 🙌