Part1 handler QueryUserByName
WenyXu opened this issue · 2 comments
WenyXu commented
func (srv *Service) QueryUserByName(ctx context.Context, req *userProto.Request, rsp *userProto.Response) error {
user, err := userService.QueryUserByName(req.UserName)
if err != nil {
rsp.Success = false
rsp.Error = &userProto.Error{
Code: 500,
Detail: err.Error(),
}
return err
}
rsp.User = user
rsp.Success = true
return nil
}其中这个地方是不是应该修改成 return nil?
if err != nil {
rsp.Success = false
rsp.Error = &userProto.Error{
Code: 500,
Detail: err.Error(),
}
return nil //修改成 return nil
}如果是 return err 会直接抛出 err ,没有 response
printfcoder commented
是的,麻烦改下,pr?
WenyXu commented
OK