prisma-labs/graphqlgen

chore: better use of prettier for contributors

jasonkuhrt opened this issue · 1 comments

jasonkuhrt commented

Changes suggested

  1. place prettier config in package.json instead of own prettier file
  2. maybe: place prettier config in every package.json (required by vscode option "prettier.requireConfig": true. [1]
  3. not everyone uses pre-commit hooks, slick/configured IDEs, and sometimes commits come through github itself (e.g. suggestion edits). For all these reasons and probably more, I think https://www.prettierci.com/ would be useful. The goal is make contributions as easy as possible!
  4. setup pretty-quick + husky

Notes

  1. However arguably the vscode plugin option should traverse up (or have an option to) to the first prettier config found along the ancestors folder path. I've made an issue for that prettier/prettier-vscode#664. However until then maybe this project should adjust?
jasonkuhrt commented

About point two above, it seems to be working now. I think it was because I didn't have tslint enabled in my VSCode. Anyway, by changing root package.json prettier config I am able have all sub-packages honour that config. 👍