Support prevrandao opcode

Question

Support prevrandao opcode

ChihChengLiang opened this issue 2 years ago · 16 comments

After the Merge, the DIFFICULTY opcode was renamed to PREVRANDAO

            difficulty: if eth_block.difficulty.is_zero() {
                eth_block
                    .mix_hash
                    .unwrap_or_default()
                    .to_fixed_bytes()
                    .into()
            } else {
                eth_block.difficulty
            },

another remainder is that we need to support prevrandao opcode (renamed from DIFFICULTY). I make this change https://github.com/scroll-tech/zkevm-circuits/blob/1ea9b5970ff873191de29e625687765f427326dd/bus-mapping/src/circuit_input_builder/block.rs#L119-L127 to be compatible with latest node/libs.

Originally posted by @lispc in #1362 (comment)

References

Answer 1 · 2023-06-27T05:23:24.000Z

@ChihChengLiang is this open to take up?

Answer 2 · 2023-06-28T09:22:58.000Z

Hi @ameya-deshmukh,
Thanks for your interest in contributing to this task.
Yes, the issue is open to take up. But it would be great if you could help update the spec first privacy-scaling-explorations/zkevm-specs#437.

Answer 3 · 2023-07-02T13:18:24.000Z

Great, thank you!

Answer 4 · 2023-08-21T10:27:43.000Z

Is this issue working in progress? Maybe I can help for it, we met this issue and added in our project. @ChihChengLiang @ameya-deshmukh

Answer 5 · 2023-08-29T12:19:31.000Z

Hi @ameya-deshmukh, Can you give an update? It's okay if you are too busy and not able to work on this task.

Answer 6 · 2023-08-31T13:37:29.000Z

Hi @ameya-deshmukh, Can you give an update? It's okay if you are too busy and not able to work on this task.

So, may I claim this?

Answer 7 · 2023-08-31T13:38:43.000Z

Hey @dyxushuai would you like to work on it together? I wasn't able to get started on this.

Answer 8 · 2023-08-31T13:40:38.000Z

Hey @dyxushuai would you like to work on it together? I wasn't able to get started on this.

Of course, I will begin to do this ASAP

Answer 9 · 2023-08-31T13:41:33.000Z

Where can we communicate? We can split up the tasks.

Answer 10 · 2023-08-31T13:44:02.000Z

@ameya-deshmukh You can email me by johnxu@duck.com

Answer 11 · 2023-08-31T14:07:44.000Z

difficulty: if eth_block.difficulty.is_zero() {
eth_block
.mix_hash
.unwrap_or_default()
.to_fixed_bytes()
.into()
} else {
eth_block.difficulty
},

I think this logic is good enough to fit the eip-4399 🐶, but we don't like Geth, we don't have flags for features or forks, so we can only keep forward compatibility

Answer 12 · 2023-09-19T03:54:24.000Z

Hey @dyxushuai and @ameya-deshmukh, could you give an update? It's fine if both of you are busy and unable to work on this task.

Answer 13 · 2023-09-20T07:16:34.000Z

Where can we communicate? We can split up the tasks.

Hey @dyxushuai and @ameya-deshmukh, could you give an update? It's fine if both of you are busy and unable to work on this task.

Sorry, I think @ameya-deshmukh didn't message me. So, I will give a PR in the next few days alone.

Answer 14 · 2023-09-20T07:18:41.000Z

Sure! Sorry I couldn't devote time to this.

Answer 15 · 2023-10-05T09:31:48.000Z

It seems no one is currently working on this issue, so I left it unassigned (please let me know if this is not the case!)

Answer 16 · 2023-10-07T07:37:43.000Z

It seems no one is currently working on this issue, so I left it unassigned (please let me know if this is not the case!)

Sorry, I just got back from a long vacation. (2 weeks)

@ed255 @KimiWu123 #1648 This is my implementation of prevrandao opcode. If you find any problems, please let me know, for now, I can respond ASAP.