Two `Word` types in zkEVM codebase
zemse opened this issue · 3 comments
zemse commented
Describe the feature you would like
Currently, there are two Word
types in the codebase
- zkevm_circuits::util::word::Word has two limbs.
- eth_types::lib::Word which is alias of U256.
It would be great if one of these is renamed.
Additional context
No response
rrtoledo commented
There were some proposals for Circuit's words at an online meeting including:
- ZWord
- CWord
- WordLimbs
- WordCell
rrtoledo commented
There are also some types with the same names in bus mapping and zkevm-circuits such as Block
(defined in bus-mapping/src/circuit_input_builder/block.rs and zkevm-circuits/src/witness/block.rs).
Do you think we should open an issue per homonyms or turn this one here for all?
ChihChengLiang commented
@rrtoledo Let's address the renaming of the Blocks in a new issue.
Feel free to choose any name you see fit for Word.