Rename all instances of RwTableTag by Target
ChihChengLiang opened this issue · 6 comments
ChihChengLiang commented
RwTableTag is replaced by Target in the circuit PR privacy-scaling-explorations/zkevm-circuits#1406
We should rename RwTableTag to Target for consistency.
https://github.com/search?q=repo%3Aprivacy-scaling-explorations%2Fzkevm-specs%20RwTableTag&type=code
Originally posted by @ed255 in privacy-scaling-explorations/zkevm-circuits#1406 (review)
th3093 commented
still open?
ChihChengLiang commented
@th3093 The issue is still open. Feel free to take it.
th3093 commented
Done. Where to PR or commit? Sry, this is my first contribution and I don't want to break shit:D
ChihChengLiang commented
Hi @th3093,
Please send a pull request to this repo, i.e. https://github.com/privacy-scaling-explorations/zkevm-specs.
th3093 commented
Ok did it. Thanks:)
ChihChengLiang commented
Fixed in #431