privacy-scaling-explorations/zkevm-specs

Integrate precompiles into callop

KimiWu123 opened this issue · 3 comments

KimiWu123 commented

Currently, our precompile gadgets are all individual verification gadgets, but we need to integrate these precompile gadgets into callop (bcs precompiles are part of callop). Could refer to Scroll's implementation: https://github.com/scroll-tech/zkevm-circuits/blob/2e06a0f4d089c2c01f2f62f44dc4a2ed354f4d28/zkevm-circuits/src/evm_circuit/execution/callop.rs#L315-L523

ed255 commented

Is this issue resolved via privacy-scaling-explorations/zkevm-circuits#1628 ? We need to investigate. @ChihChengLiang will take a look at this.

ChihChengLiang commented

Update: 🙈 Sorry, this task remains to be worked. I just realized I'm at the spec repo not the circuit repo.

I can confirm the precompile part of the callop gadget is handled in #1628
See https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/1628/files#diff-e72a6a818cbda6c14cb551573432e59fe61ce109345dd4c088508a60c27979af

  • 👍1
  • 😄1
KimiWu123 commented

Yep, this is about the spec not the circuit. We need to sync the spec with the circuit. 😄