Consider removing VERSION, or enforce that people updating tags use it properly/create PRs
fsaad opened this issue · 1 comments
For bayeslite and several other repositories, people pushing tags have not been correctly updating the VERSION file as required. This foresight will cause problems and confusion between git tags, conda release version, the version reported by bayeslite.version in python, and even potentially cause python setup.py build to fail.
We should:
-
Be explicit that tagging should be done via a PR requested a tag: versioned release tags are managed and approved by a set of disciplined maintainers.
-
Implement 1., and consider replacing VERSION with the method I am using the
trcrpmsetup.py file. "Disciplined maintainers" can also mess up VERSION bumping, so something more automated might be better.
I must say I do not know the full reasoning behind why VERSION was designed like this or other python projects which use the convention, but I do believe it is a good convention provided that VERSION bumping was always done correctly.