probe-lab/zikade

Flaking test: TestDHT_SearchValue_quorum_test_suite/TestQuorumReachedPrematurely

Closed this issue · 9 comments

iand commented

This test run failed on a PR with no code changes

https://github.com/plprobelab/zikade/actions/runs/6408785740/job/17398549960?pr=47

--- FAIL: TestDHT_SearchValue_quorum_test_suite (10.79s)
    --- PASS: TestDHT_SearchValue_quorum_test_suite/TestQuorumReachedAfterDiscoveryOfBetter (0.27s)
    --- FAIL: TestDHT_SearchValue_quorum_test_suite/TestQuorumReachedPrematurely (10.15s)
    --- PASS: TestDHT_SearchValue_quorum_test_suite/TestQuorumUnspecified (0.18s)
    --- PASS: TestDHT_SearchValue_quorum_test_suite/TestQuorumZero (0.17s)
dennis-tra commented

Still relates to libp2p/go-libp2p#2589 if we extended the test timeout this will work

iand commented

I will try that

dennis-tra commented

I'm just experimenting with #50

iand commented

I've been unable to reproduce this locally.

I ran go test -count 1000 -failfast -run TestDHT_SearchValue_quorum_test_suite without any failures.

My system:

14:48 $ uname -a
Linux astrolith 6.1.0-10-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.38-1 (2023-07-14) x86_64 GNU/Linux
dennis-tra commented

Yeah, it's also working fine on my machine... I tried to change the local dial timeout in #50. Tests are running currently. Let's see if that helped.

dennis-tra commented

was auto-closed because I mentioned it in the pull request. Can reopen if the problem persists

  • 👍1
dennis-tra commented

Happened again: https://github.com/plprobelab/zikade/actions/runs/6459054917/job/17534078617?pr=60

This time it's probably a different reason

iand commented

This hasn't reoccured since we fixed the deadlock in #63