Make include guards unique

Question

Make include guards unique

elfring opened this issue 10 years ago · 3 comments

I find that include guards like "DPX_H" and "TASK_H" are too short for the safe reuse of your header files.

Answer 1 · 2014-08-06T21:10:15.000Z

For DPX_H, I don't think we'll hit anything significant. I'm willing to change it to DUPLEX_H just in case.

As for TASK_H, since we're already vendoring libtask, I will most likely be -Wl,--whole-archive'ing it into libdpx.so so that's one less library that clients have to worry about, and therefore task.h won't even matter.

Answer 2 · 2014-08-07T05:45:39.000Z

How do you think about to make them unique by appending a kind of UUID?

Answer 3 · 2014-08-07T05:57:15.000Z

That seems like a little overkill. It's pretty easy to manually fix this yourself in the rare case it's not good enough.