`CancelOrderByClientIdV2` API should take `NonZeroU64` and not `u64`.
tommyip opened this issue · 0 comments
tommyip commented
The instruction accepts an u64
:
serum-dex/dex/src/instruction.rs
Line 434 in 0c23a51
despite it being casted to a
NonZeroU64
internally:Line 2127 in 0c23a51
which means that an order with client id of 0
can not be cancelled (raising an assertion error).
This is also an issue for the CancelOrdersByClientIds
instruction, worst yet it silently filters away the 0
id order:
Lines 2190 to 2194 in 0c23a51
Causing confusing errors like insufficient funds.