project-topaz/topaz

Inconsistent effect names

TeoTwawki opened this issue · 2 comments

I have:

  • searched existing issues (http://project-topaz.com/issues/) to see if the issue has already been opened
  • checked the commit log to see if the issue has been resolved since my server was last updated

Additional Information (Steps to reproduce/Expected behavior) :
https://github.com/project-topaz/topaz/blob/release/src/map/status_effect.h line 82

https://github.com/project-topaz/topaz/blob/release/scripts/globals/status.lua line 182 (can’t direct link to line on mobile)

We need one single convention, either underscore and a 1 or not, but not half one cor the core and half the other in lua. This is likely what lead to the issue solved in #1448 so lets pick one and make sure all effects with multiple versions are done the same way.

For Curse, I will merge a Pull Request that changes all "Curse 1" to just curse, and "Curse 2" (ST20) to "Zombie".

am concerned having names of effects not match client will potentially cause additional confusion points. in the dats, both curses are just listed as "curse". I swear to god there were three but Bane is its own effect now apparently, sitting at the ID I thought was our man.