`#include <math.h>` in inc/*.h files have no reason to be there

Question

`#include <math.h>` in inc/*.h files have no reason to be there

Closed this issue 6 years ago · 1 comments

this actually causes problems if NE10.h is included in a file that then includes <cmath>.
The #include <math.h> line should be in the .c files where appropriate. A number of other includes in NE10.h and a bit all over the place are pointless and should be removed.

Answer 1 · 2018-11-08T23:08:42.000Z

Thank you for contribution. I agree it make no sense to include the headers in the API headers. Could you update your pull request to fix the failures. It is OK to remove the NULL in our macros.
One more thing, please make sure you have commit the change with the Sign-off-by line. Refer to Contributing.md for this requirement.