projectdiscovery/proxify

Bug: too many colons in address

nicoandmee opened this issue · 1 comments

Proxify version:

0.0.8

Current Behavior:

╰─➤  proxify -socks5-proxy 'socks5://51.91.197.148:10002' -output "$(date +%Y%m%d)"                                                                                                                                                                                     130 ↵

                       _ ___
   ___  _______ __ __ (_) _/_ __
  / _ \/ __/ _ \\ \ // / _/ // /
 / .__/_/  \___/_\_\/_/_/ \_, /
/_/                      /___/  v0.0.8

                projectdiscovery.io

[INF] HTTP Proxy Listening on 127.0.0.1:8888
[INF] Socks5 Proxy Listening on 127.0.0.1:10080
[INF] Saving proxify traffic to 20221125
[INF] Using upstream SOCKS5 proxies: ["socks5://51.91.197.148:10002"]
2022/11/25 08:19:57 [002] WARN: Cannot read TLS response from mitm'd server socks connect tcp: dial tcp: address socks5://51.91.197.148:10002: too many colons in address
2022/11/25 08:19:57 [004] WARN: Cannot read TLS response from mitm'd server socks connect tcp: dial tcp: address socks5://51.91.197.148:10002: too many colons in address
2022/11/25 08:19:57 [006] WARN: Cannot read TLS response from mitm'd server socks connect tcp: dial tcp: address socks5://51.91.197.148:10002: too many colons in address
2022/11/25 08:19:57 [008] WARN: Cannot read TLS response from mitm'd server socks connect tcp: dial tcp: address socks5://51.91.197.148:10002: too many colons in address
2022/11/25 08:19:57 [010] WARN: Cannot read TLS response from mitm'd server socks connect tcp: dial tcp: address socks5://51.91.197.148:10002: too many colons in address
2022/11/25 08:19:58 [012] WARN: Cannot read TLS response from mitm'd server socks connect tcp: dial tcp: address socks5://51.91.197.148:10002: too many colons in address
2022/11/25 08:19:58 [014] WARN: Cannot read TLS response from mitm'd server socks connect tcp: dial tcp: address socks5://51.91.197.148:10002: too many colons in address
2022/11/25 08:19:58 [016] WARN: Cannot read TLS response from mitm'd server socks connect tcp: dial tcp: address socks5://51.91.197.148:10002: too many colons in address
2022/11/25 08:19:58 [018] WARN: Cannot read TLS response from mitm'd server socks connect tcp: dial tcp: address socks5://51.91.197.148:10002: too many colons in address
2022/11/25 08:19:58 [020] WARN: Cannot read TLS response from mitm'd server socks connect tcp: dial tcp: address socks5://51.91.197.148:10002: too many colons in address
2022/11/25 08:20:00 [024] WARN: Cannot read TLS response from mitm'd server socks connect tcp: dial tcp: address socks5://51.91.197.148:10002: too many colons in address
2022/11/25 08:20:00 [026] WARN: Cannot read TLS response from mitm'd server socks connect tcp: dial tcp: address socks5://51.91.197.148:10002: too many colons in address

Expected Behavior:

A colon should not be appended to the end of the address. As you see, I did not include it in my invocation.

Steps To Reproduce:

See command I ran

Anything else:

Thanks for making awesome tools :)

The issue seems to be the docs? https.go makes it appear the format should be host:port, no protocol prefix. If I am correct, let me know so I can submit a PR. <3

Clarification: When using host:port, it works without issue.