projectsyn/commodore

Commodore's template sync creates PRs even if there's no actual changes

simu opened this issue · 0 comments

simu commented

Commodore's template sync creates essentially empty PRs when ran after a change to the template which only affects a few dependencies, see e.g. projectsyn/component-cert-manager#105. This is not ideal, and we should ensure that we only create PRs for dependencies which have actual changes (other than the template repo commit ID).

Steps to Reproduce the Problem

  1. Make a template change which only applies to a subset of dependencies (e.g. projectsyn/commodore-component-template#18)
  2. Observe that the template sync logic creates a PR for components which has no changes (e.g. projectsyn/component-cert-manager#105)

Actual Behavior

The template sync interprets the changed template commit ID as a change in the dependency's boilerplate. While technically true, it's not worth it to actually create a PR which only bumps the template commit ID.

Expected Behavior

The template sync only creates PRs for dependencies which have non-trivial changes.