[Bug]: Crit Damage Lore Display

[gMithos]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

Crit Damage Item stat displays as a % but works as a multiplier. +2% Crit Damage is instead x2 Crit Damage. The issue is in the format of the lore

Expected Behavior

It should display as a multiplier, or display as a % and work as a %.

Steps To Reproduce

No response

Environment

- Server Software:
- ProRPGItems Version:
- ProMCCore Version:
- Plugins:

latest.log

No response

Anything else?

No response

[Travja]

Hey @gMithos sorry this has taken me so long to actually look into. From the code side, this looks like the display is behaving properly, but it's the actual damage that's behaving wrong. From the code side, the item should be considered a "main item" in order for it to display as 2x for example. For this to be true, the item must be a weapon as defined in the plugin configuration. If this is not the case, it should be treated as a "bonus" item, if you will, where if the item is added to the player's equipment (either in their hand or worn as armor), the item should apply as a percent bonus instead.

So there are kind of two options... 1. Add the item's Material to your config so it properly reflects as a weapon and uses the Yx format, or 2. I can fix the damage calculations to properly apply this stat as a percent.