prometheus-community/helm-charts

[prometheus-snmp-exporter] When adding an additional metric label that a number wrapped by strings, gets templated out as an int.

EStork09 opened this issue · 0 comments

Describe the bug a clear and concise description of what the bug is.

        additionalMetricsRelabels:
          site: words
          room-number: "8576"

gets rendered as:

      - targetLabel: room-number
        replacement: 8576
        action: replace

What's your helm version?

v3.15.1

What's your kubectl version?

v1.27.9-dispatcher

Which chart?

prometheus-snmp-exporter

What's the chart version?

5.1.0

What happened?

When passing in a quoted string for a label, it gets converted to an int and isn't valid in prometheus crd

What you expected to happen?

All values you should always be quoted since you cannot have an int as a prometheus label.

How to reproduce it?

        additionalMetricsRelabels:
          site: words
          room-number: "8576"

Enter the changed values of values.yaml?

  serviceMonitor:
    enabled: true
    additionalMetricsRelabels:
        site: words
        room-number: "8576"

Enter the command that you execute and failing/misfunctioning.

helm template . > output.yaml

Anything else we need to know?

No response