prometheus-community/helm-charts

[kube-prometheus-stack] Allow custom annotations to be added to admission webhook configurations

rorynickolls-skyral opened this issue · 0 comments

Is your feature request related to a problem ?

The admission webhook patch job for Prometheus Operator fails when deployed in ArgoCD's PreSync phase (as suggested in the values file), because it requires the ValidatingWebhookConfiguration and MutatingWebhookConfiguration to be present.

Currently these resources do not support custom annotations, so there is no way to ensure they are created in the same phase as the patch job.

Describe the solution you'd like.

Allow custom annotations to be added to these webhook configurations and any other resources required by the patch job.

Describe alternatives you've considered.

  • Attempting to get everything ordered correctly in the Sync phase using sync waves. This creates some different issues relating to startup order/race conditions between the operator and patch job.

Additional context.

No response