prometheus-community/ipmi_exporter

make power consumption collection optional

propertone opened this issue · 7 comments

propertone commented

Thanks for creating this exporter! Some hardware (eg: Cisco) does not appear to support the ipmi dcmi extension, so the ipmi-dcmi command fails with:
ipmi_cmd_dcmi_get_power_reading: command invalid or unsupported

Can you make it so that the collector still collects the monitoring data even if the dcmi command fails?

Some ideas:

  • Add a flag to disable ipmi-dcmi
  • Add ipmi_dcmi_up metric to indicate whether dcmi command succeeded, and proceed even if it fails.
  • Run ipmimonitoring before ipmi-dcmi, and set ipmi_up to 0 only if bmc-info or ipmimonitoring commands fail
  • Detect whether DCMI is supported before running the ipmi-dcmi command (not sure how to do that).
bitfehler commented

Hi,
yes, that certainly makes sense. I'll consider this for inclusion in the next update (coming soon).

  • 👍1
bitfehler commented

@propertone this should be fixed with 109c7ca, with more improvements around this to be coming a little later. Can you confirm that this at least makes it work for you?

  • 👍1
RajKiranS commented

@bitfehler , On behalf of @propertone, I confirm that its working as expected. The DCMI is being skipped wherever it has problems and rest of the metrics are queried. Thanks much!

bitfehler commented

Great to hear, thanks! More fine-grained control over this will be added later on.