[request]: Add option to label deployment in Helm chart
marevers opened this issue · 1 comments
Proposal
Use case. Why is this important?
Currently it is not possible to put labels on the deployment via the Helm chart. There are labels
fields for the pod and the service but not for the deployment itself. We strongly use labels to categorize our deployments and it would be helpful if we were able to do so for this exporter as well.
How do you think the new configuration should look like?
I think there are two options to solve this request.
-
pod.labels
also gets applied to the deployment itself.
Disadvantage is that there is no way to have control over the pod and deployment labels separately, but the question is whether those should be differentiated anyway. I think not. -
Add a separate field to add labels (and maybe annotations) to the deployment.
Example for values.yaml
:
deployment:
labels: {}
annotations: {}
I just realised I opened this in the wrong repository. This should be in prometheus-community/helm-charts. Closing.