propublica/campaign_cash

Candidate.search offset param?

tcopple opened this issue · 3 comments

tcopple commented

Is there a reason the Candidate.search(...) method does not take any form of an offset parameter?

I have a fork where I've changed all API calls to take a named optional hash as the last parameter, allowing them to participate in options in the Base.invoke method. Is this something you'd be interested in merging in? If so I'll create the pull.

If not, answering the first question is enough for me.

Thanks, great work so far.

dwillis commented

No good reason, no. Lemme take a look at your fork, but I think in the near term we can simply make the change on Candidate.search if there are any concerns.

dwillis commented

I didn't see the changes in your fork, but I added offset to the Candidate methods in the latest version (2.3), out today.

tcopple commented

Sorry, I haven't pushed to the fork yet, I'll get it done this weekend.
Thanks.

On Thu, Mar 15, 2012 at 1:23 PM, Derek Willis <
reply@reply.github.com

wrote:

I didn't see the changes in your fork, but I added offset to the Candidate
methods in the latest version (2.3), out today.

Reply to this email directly or view it on GitHub:
#17 (comment)