protofire/solhint

Low sensitivity of explicit-types

0xVolosnikov opened this issue · 3 comments

0xVolosnikov commented

The explicit-type rule is not checked when casting a variable.

Example

Option: explicit

function test() external {
  uint256 a = uint(10);
}

Expected: error because of uint(10)

Observed: no errors

dbale-altoros commented

@vladyan18 that's a good catch
I'll try to fix it in next release

Feel free to submit a PR to correct this
Much appreciated

Thanks for posting!

0xVolosnikov commented

Feel free to submit a PR to correct this Much appreciated

Already done :)

#493

dbale-altoros commented

ohh I seee
GREAT WORK!!
I will review it asap

THANKS A LOT!