prysmaticlabs/prysm

Cleaning up p2p address util functions

Opened this issue ยท 1 comments

๐Ÿ’Ž Issue

Background

I was looking to work for #14166, and found there are several functions for converting different formats of p2p addresses(enode, ENR, multiaddr). For example, PeersFromStringAddrs for setting trusted peers from static peers works almost identically with parsePeersEnr in pubsub.go. Also MakePeer calls AddrInfoFromP2pAddr from go-libp2p/core/peer, just like other util functions do.

Description

I would like to deal with this redundancy to enhance dx and readbility for future work. I'd like to address #14166 also, by adding all types(enode, ENR, multiaddr) are acceptable. Could you assign for these tasks?

Thanks so much @syjn99. Could you please comment on #14166? I can't assign you unless you interact with that github issue.