psalaets/excel-formula-parser

BinaryExpressionNode doesn't cover all possible operator types

mrkev opened this issue · 3 comments

mrkev commented

This parses:

image

Yet the type seems to be:

export interface BinaryExpressionNode {
  type: 'binary-expression',
  operator: '>' | '<' | '=' | '>=' | '<=' | '+' | '-' | '&',
  left: Node,
  right: Node
}

Note the "*" is missing, which typescript raises as an issue:

image
mrkev commented

Also applies to /, ^ and <>

psalaets commented

Thanks for the bug report. Can you submit a PR for this?

mrkev commented

Sure, will do on a spare minute

  • 👍1