can we port this into core?

Question

Opened this issue 7 years ago · 8 comments

Hey, I was wondering if we can port some refactored form of this into pytorch?

Done!

Answer 1 · 2017-11-18T21:32:07.000Z

(because the repo does not have a license)

Answer 2 · 2017-11-18T21:32:55.000Z

Oh yeah sure. Would be happy to help with that too! Let me add a license today, which one would work best for PyTorch?

Answer 3 · 2017-11-18T21:33:57.000Z

standard BSD 3 clause, like in pytorch.

thank you.

Answer 4 · 2017-11-18T21:43:04.000Z

thank you.

Answer 5 · 2018-01-09T23:55:10.000Z

@soumith Is this already in pytorch? Would love to import it directly!

Answer 6 · 2018-01-10T00:02:37.000Z

istft isn't in core pytorch yet, it's being worked upon.
Follow pytorch/pytorch#3775 for progress

Answer 7 · 2019-12-07T07:34:42.000Z

istft isn't in core pytorch yet, it's being worked upon.
Follow pytorch/pytorch#3775 for progress

Does it mean that torch.stft is the optimized version of this stft-pytorch repo?