psf/pyperf

Warn when bench command with `--tracemalloc`

oraluben opened this issue · 2 comments

oraluben commented

pyperf command only supports the --track-memory option, and not the --tracemalloc:

pyperf/pyperf/_command.py

Line 50 in 968f247

if self.args.track_memory:

Do you think it's better to have a warning (or just a fatal) here?

vstinner commented

Do you want to propose a PR to implement this idea?

--tracemalloc is not usable with pyperf command.

oraluben commented

--tracemalloc is not usable with pyperf command.

Naturally. But I didn't realize that before digging into the code. Also, is there any doc specifying that?

Do you want to propose a PR to implement this idea?

I can do that.