Game Crash when opening game menu using 'P' key or 'M' key

Question

Game Crash when opening game menu using 'P' key or 'M' key

KitKatMeowski opened this issue 4 years ago · 22 comments

Narrowed this down to mods using GameUI, including the Demo mod 'whereami'.
Tested this by disabling (completely removing all mods from "\bin\x64\plugins\cyber_engine_tweaks"), confirmed the game was no longer crashing.

Added my own WIP mod first, confirmed the crash occurs with my mod enabled.
Confirmed further that the issue is caused when using GameUI, by testing with just the Demo mod enabled and no other mods.

Steps to reproduce:
install just the whereami mod from the README and press M to view the map or J for journal, or P for the in-game menu.
Issue doesn't occur if i press i to bring up the menu, or escape.

Stack Trace from the CP77 Crash Reporter:
Error reason: Unhandled exception

Expression: EXCEPTION_ACCESS_VIOLATION (0xC0000005)
Message: The thread attempted to read inaccessible data at 0x10000002F.
File: <Unknown>(0)

Answer 1 · 2021-03-09T17:50:48.000Z

I know of the crash when opening the Map using the controller (holding start button). I tried to reproduce it on keyboard and no crash for me. Did you have a controller connected while testing this?

Answer 2 · 2021-03-09T21:56:22.000Z

Yes I did have an XBox controller connected. I have removed the controller and tried restarting my PC, still getting the crash.

Answer 3 · 2021-03-10T11:34:27.000Z

By the way, until I found the workaround let me know how you planning to use GameUI. I can help you to integrate the lib and probably avoid the crash with current version.

Answer 4 · 2021-03-10T11:46:16.000Z

Making a mod that is only relevant in the New Game > Character Creation / Appearance editor Menu and should not be displayed or running in any other context. At the moment I use GameUI to check when the player is in this menu, and when they leave the menu.

Really all I need is to know when they are in the Character Creation screen and when they leave.

registerForEvent('onInit', function()

    GameUI.Observe(function(state)
        -- Is Player in the Character Appearance screen?
        if state.menu == 'NewGame' and state.submenu == 'Customization' then
            -- Show Window

        elseif state.lastSubmenu == 'Customization' then
            -- Hide Window
        end
    end)
end)

Answer 5 · 2021-03-10T12:18:12.000Z

You can use this snippet instead of GameUI:

registerForEvent('onInit', function()
    Observe('MenuScenario_CharacterCustomization', 'OnEnterScenario', function()
        -- Show Window
    end)
    Observe('MenuScenario_CharacterCustomization', 'OnLeaveScenario', function()
        -- Hide Window
    end)
end)

Answer 6 · 2021-03-17T07:09:39.000Z

I committed potential fix. Can you try it?

Answer 7 · 2021-03-17T07:16:13.000Z

Will do! Currently at work, but I will test this as soon as I get home.

Answer 8 · 2021-03-17T09:26:53.000Z

Sadly this is still occurring for me with the new GameUI version 0.9.7.
Not that it will help, but can I possibly provide you with anything from the crash report, or the whole thing sav included?

Answer 9 · 2021-03-17T09:39:34.000Z

I doesn't seem to be related to the save (game state), I checked this with another modder.

But it would be very helpful if you can try something else. Since I can't reproduce the crash it's hard to find the exact place where the crash is happening. I have three main suspicions.

Observer for SwitchToScenario on lines 466-472
Observer for OnOpenMenuRequest on lines 482-488
Observer for OnCloseHubMenu on lines 490-495

If you can try commenting them out one by one to find which one is failing this would be a major help.

Answer 10 · 2021-03-17T09:51:24.000Z

The issue doesn't occur when the block below is commented out

Observer for SwitchToScenario on lines 466-472

Answer 11 · 2021-03-17T10:04:26.000Z

Thank You! And it's a good news because I know at least one alternative for this code. I'll prepare it soon.

Answer 12 · 2021-03-17T10:15:15.000Z

Awesome! thank you for looking into it

Answer 13 · 2021-03-17T10:18:26.000Z

Pushed an update.

Answer 14 · 2021-03-17T10:26:16.000Z

No go still the same issue with SwitchToScenario. Wonder why my environment is so different.

Answer 15 · 2021-03-17T10:30:06.000Z

So now OnEnterScenario causes the crash? If you comment this new part 466-476 then no crash?

upd: btw I only updated the main file and not the ones on the examples.

Answer 16 · 2021-03-17T10:39:19.000Z

Actually no, I am wrong this is not happening now. I was using the GameUI with the whereamI mod to test not the version you just updated sorry.

Let me test it also with the code I had one second

Answer 17 · 2021-03-17T10:46:25.000Z

Looks like its fixed to me! Cant get it to happen again. Sorry for the confusion there for a second

Answer 18 · 2021-03-17T10:59:50.000Z

Ok so the game no longer crashes when opening the menu from within an active game, however I now get a crash in my code just after selecting Game difficulty in the New Game menu. Commenting out lines 466-476 stops the crash from occurring.

Answer 19 · 2021-03-17T11:25:57.000Z

Trying something new, will update soon.

Answer 20 · 2021-03-17T11:50:11.000Z

Pushed new version.

Answer 21 · 2021-03-17T13:23:46.000Z

Got the new version and tested in game and in the new player menu.
No more crash! xD I think we have it!
Sorry I had to disappear for a short while.

Answer 22 · 2021-03-17T14:01:50.000Z

Oh man, it's so good to hear .)