psibi/dhall-mode

REPL support looks for `dhall-repl` command

Closed this issue · 3 comments

endgame commented

Unlike the dhall format support, a quick scan of the code makes me think that the repl support unconditionally looks for dhall-repl instead of trying to run dhall repl.

psibi commented

Yeah, that's right:

dhall-mode/dhall-mode.el

Line 305 in ef4d33d

(defcustom dhall-repl-executable "dhall-repl"

I wouldn't be opposed adding a new defcustom like dhall-repl-arguments to support other workflow.

purcell commented

Sorry @psibi, I was pushing a fix for this while you were writing your comment. I think the right thing to do these days is just to use dhall-command, ie. "dhall" and run dhall repl unconditionally.

psibi commented

No worries @purcell :-) Thanks for the fix!

  • 👍1