Integrate Pull Request for closing off click

Question

Integrate Pull Request for closing off click

Closed this issue 4 years ago · 5 comments

Are you able to add in this pull request to your build? I have about 8 selects on a page and if you click on one, and then another, they all just stay open.

This pull looks like it will address the issue by closing others when clicking on a new one.

Thoughts?

valor-software#712

Answer 1 · 2017-08-18T02:16:47.000Z

Sure I can request the creator of that PR to open a PR to my fork as well

Answer 2 · 2017-08-18T02:21:40.000Z

Actually I was just able to create a PR anyway #13

However there are merge conflicts. Maybe you or someone else could create another PR that resolves those merge conflicts. I'm betting the conflicts aren't anything major.

Answer 3 · 2017-08-21T14:16:10.000Z

I will try and figure that out - pretty new to git so I will need to determine what those conflicts are to be able to address them. Will try and update you shortly.

Answer 4 · 2017-09-07T15:10:45.000Z

@carlhussey hey sorry I went on vacation and forgot to reply, but I meant to tell you if you ever want help I don't mind hopping on a screenshare.

Answer 5 · 2017-09-07T15:20:30.000Z

Thanks for the reply - I will probably try and tackle this over the weekend. I have a big need for it now, just gotta figure out how to use git in order to test and fix the conflicts.

…

On Thu, Sep 7, 2017 at 8:10 AM, Syed Akber Jafri ***@***.***> wrote: @carlhussey <https://github.com/carlhussey> hey sorry I went on vacation and forgot to reply, but I meant to tell you if you ever want help I don't mind hopping on a screenshare. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#12 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFvlWkKDaWadwPN4bBGLYcjN6qe_2bcCks5sgAd2gaJpZM4O6noJ> .