ptarmiganlabs/butler-sos

Config file verification happens too late during startup and does not always exit the program

Closed this issue · 0 comments

mountaindude commented

What version of Butler SOS are you using?

10.1.1

What version of Node.js are you using? Not applicable if you use the standalone version of Butler SOS.

20

What command did you use to start Butler SOS?

node ./src/butler-sos.js --loglevel info --configfile ./src/config/production.yaml

What operating system are you using?

Linux

What CPU architecture are you using?

x86_64

What Qlik Sense versions are you using?

2024 May

Describe the Bug

  1. Config file verification should happen as early during startup as possible
  2. In some cases a failed verification does not exit Butler SOS (which should be the case in that scenario).
  3. For example, when some array's (in the config file) parent does not exist. In that case there is not a perfect feedback message from Butler SOS about what is missing/incorrect, and Butler SOS keeps running.

Expected Behavior

  1. Move verification to beginning of app startup
  2. Hard to give better error message (possible but takes lots of work, no clear way of solving it), but Butler SOS should at least ALWAYS exit when incorrect config file format is detected.

To Reproduce

No response