Any plan to merge react-native newer version?

Question

Any plan to merge react-native newer version?

beretboat opened this issue 7 years ago · 10 comments

Last merged react-native version is v44, which use react v16.0.0-alpha.12.
react v16 rc supports fragments (returning arrays from components), a long-expected feature.

Answer 1 · 2017-10-27T08:50:49.000Z

Sure, I do have plans. There a lot of changes such as metro-bundler (decoupled from react-native packager). React 16 Fiber also is very welcomed. I'm waiting for it to stabilize, and before this work I'm upgrading my casual React Native iOS / Android projects.

I guess I can close it since, it's a question.

Answer 2 · 2017-10-27T09:02:09.000Z

Thanks. Glad to hear.

May I ask when will it happen? In days, weeks, or months? Just a rough estimation, it does not have to be a accurate time.

Answer 3 · 2017-10-27T09:08:02.000Z

After 0.50 will be finally released https://github.com/facebook/react-native/releases I'll try it on my projects and will start merging I guess (it usually takes 2-5 days). If it's not ok, or there is a very important feature that I need to wait for 0.52 then, that means +1 month.

…

On Fri, 27 Oct 2017 at 12:02 beretboat ***@***.***> wrote: Thanks. Glad to hear. May I ask when will it happen? In days, weeks, or months? Just a rough estimation, it does not have to be a accurate time. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#180 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA9SU-_1RUhYgLDmNuRfW-i0PAmu6qePks5swZwUgaJpZM4QIoRR> .

Answer 4 · 2017-10-27T09:10:47.000Z

Got it. Thanks!

Answer 5 · 2018-01-09T02:04:47.000Z

Sorry to reopen this. 0.52 has been released for a while, are you still going to merge this version?

Answer 6 · 2018-01-09T11:42:32.000Z

Yes. I started it locally. There a lot of changes, including React 16, metro bundler, revised UIExplorer -> TesterApp, moving from Travis to CircleCI, etc. 2661 files to resolve (some of them are quick and straightforward, but a hundred or so are tricky one).

Answer 7 · 2018-01-09T12:11:18.000Z

@ptmt Curious if you have a strategy for dealing with this considering you've done this a few times already. Or are you just the most patient man on the planet?

Is something you could use help with or is this a @ptmt shaped problem?

Answer 8 · 2018-01-09T13:32:57.000Z

Good to know, thanks!

Answer 9 · 2018-01-17T14:28:08.000Z

@skellock It's a good question.

I'm working right now on this, it's painfully slow because of a small amount of spare-time. But there are numerous ways to make things faster. First, extract all macOS specific components into the single repo. Something like react-native-appkit-components. The second thing is trying to pull not everything from RN but only specific pull requests (such as upgrading to React 16.2, etc.)

I think also that there are several ongoing projects that may replace this one as more successful.

Answer 10 · 2018-01-17T14:37:00.000Z

This is what it looks like. 2500 merge conflicts to resolve. 50% of them really silly and I usually do this stage fast. The rest usually are Git merge fails, and probably a more sophisticated merger software would help dramatically. I tried most of the free software available for it.

Here are a few examples:

(just need to preserve -macos here).

AppKit doesn't allow to access CGI data, so I need to use a helper. Multiple times. Probably the better solution is to add NSImage method.

But even so, 10% of the rest conflicts is where you need to really spend time. I'll do a pull request as soon as I finish this and when I'll need to set up a new CI (CircleCI) and make it all work. I would mean a lot to me if you could test it after pull request is published.