App locals should be available for all views

Question

App locals should be available for all views

Closed this issue 12 years ago · 6 comments

It would be great if the variables you define using app.locals() would be available to all
rendered / partial views. Having this ability would save us from a huge rewrite and default to the
old functionality in express < 3.0

Answer 1 · 2012-07-10T18:55:17.000Z

Hmm, I thought I had this covered already.

Could you update that test so it fails as it does in your app? Or simply give me a failing example?

Answer 2 · 2012-07-10T19:00:23.000Z

I will provide a test case :)

Answer 3 · 2012-07-10T19:00:49.000Z

Appreciate it!

Answer 4 · 2012-07-10T20:27:20.000Z

Sorry about that.. mixup on my end! :)

Answer 5 · 2012-07-10T20:29:13.000Z

Though i managed to provoke a curiosity when working with relative paths and partials.

path to view that tries to render a partial: ./views/test/promo/main

<%- partial("test/promo/sub") %>

resolves to -> ./views/sub
should be -> ./views/test/promo/sub

Answer 6 · 2012-07-10T20:43:48.000Z

Haha, glad we got that settled.

And you're right, totally missing tests for the partial lookup. Need to work on that, adding another issue for it though.

Thanks!