publiclab/plots2

Replace '.click()' with '.trigger("click")'

sainamercy opened this issue · 8 comments

sainamercy commented

💡 First Timers Issue Only

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from underrepresented groups in free and open-source software!

We know that the process of creating a pull request is one of the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Claim the issue by commenting. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
💡 Learn how to claim 🙋

Claiming an issue

Unless the issue is marked as reserved for someone, you can just say "I'd like to try this!" and then you've claimed it - no need to wait for someone to assign it to you. Just be sure you link your pull request (PR) to this issue so we can see where your solution is.

And open one early if possible - even before you've completed it with additional commits - and others can help you figure out any issues you may face.

  • 📝 Update the file like_spec.js in the publiclab/plots2 repository by replacing the deprecated .click() with .trigger("click"). (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

-   28  $("#like-button-1").click();
+  28  $("#like-button-1").trigger("click");
-   58  $("#like-button-1").click();
+  58  $("#like-button-1").trigger("click");
-   74  $("#like-button-1").click();
+  74  $("#like-button-1").trigger("click");

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in the comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming the first-timers-only issue. We're happy to keep it assigned to you as long as you need it if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below, and reach out in our chatroom!

welcome commented

Thanks for opening your first issue! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
Do join our Gitter channel for some brainstorming discussions.

sainamercy commented

@TildaDares please review if this is a viable issue

fonkwe commented

@TildaDares Can i work on this?

maryojo commented

@TildaDares I would like to work on this

TildaDares commented

This is great @sainamercy. You made me learn about the difference between click and trigger https://stackoverflow.com/a/9666559/11953728. Thank you!

  • ❤️2
TildaDares commented

Hi @maryojo, please go ahead. Thank you!

sainamercy commented

Thank you @TildaDares. I also had to research before creating the issue. It feels great to learn new things and also be of help 😊

  • 👍1
maryojo commented

Alright, I'd start working on it. Thanks @TildaDares