replace "and" with "&&" editor-controller

Question

replace "and" with "&&" editor-controller

first-timers opened this issue 2 years ago · 14 comments

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from underrepresented groups in free and open-source software!

We know that the process of creating a pull request is one of the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

🙋 Claim this issue: Claim the issue by commenting. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

💡 Learn how to claim 🙋

Claiming an issue

Unless the issue is marked as reserved for someone, you can just say "I'd like to try this!" and then you've claimed it - no need to wait for someone to assign it to you. Just be sure you link your pull request (PR) to this issue so we can see where your solution is.

And open one early if possible - even before you've completed it with additional commits - and others can help you figure out any issues you may face.

📝 Update the file app/controllers/editor_controller.rb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -35,12 +35,12 @@ def rich
       @main_image = Image.find_by(id: params[:main_image]).path
     end
 
-    if params[:tags]&.include? "lat:" and params[:tags]&.include? "lon:"
+    if params[:tags]&.include?("lat:") && params[:tags]&.include?("lon:")
       tags = params[:tags].split(',')

💾 Commit your changes
🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are not familiar with GitHub or the pull request model, here is a guide you can follow on how GitHub works.
If you are familiar with the terminal or would like to learn to use it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.

🏁 Done Ask in the comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below, and reach out in our chatroom!

Answer 1 · 2022-10-17T08:39:18.000Z

reserved for @alexanderchosen

Answer 2 · 2022-10-17T22:07:44.000Z

Would like to work on this issue.

Answer 3 · 2022-10-18T08:52:37.000Z

Would like to work on this

Answer 4 · 2022-10-18T16:52:54.000Z

Would like to work on this issue

Answer 5 · 2022-10-19T08:31:58.000Z

is it stil open? would like to try this!

Answer 6 · 2022-10-19T12:15:11.000Z

Hi @cesswairimu I noticed this has been assigned to someone. If the person isn't willing to take it up, I would like to attempt it

Answer 7 · 2022-10-19T17:24:22.000Z

Hi all, it seems AlphaRomeoMike already created a PR #11507 for this, the tests are failing maybe any of you would like to help them on the pull request? thanks all

Answer 8 · 2022-10-19T18:07:14.000Z

I would like to help @cesswairimu

Answer 9 · 2022-10-24T21:28:45.000Z

HI @TildaDares I WOLUD LOVE TO WORK ON THIS ISSUE

Answer 10 · 2022-10-25T08:04:08.000Z

let me try to fix this and see how it can be.

Answer 11 · 2022-10-26T00:07:10.000Z

Hi @cesswairimu, I would like to contribute with the specs on this issue's PR

Answer 12 · 2022-10-28T00:41:30.000Z

Hi @cesswairimu @TildaDares, I have made my first contribution and would love to help out on this.

Answer 13 · 2022-10-28T04:45:11.000Z

I'd like to work on this issue please.

Answer 14 · 2022-10-28T06:45:31.000Z

Hi @cesswairimu @TildaDares, I've finished my first contribution and please have a look at it. Thanks.