publiclab/plots2

Fix nokogumbo gem warning

cesswairimu opened this issue · 10 comments

cesswairimu commented

Logs are showing this warning

Fix `.rvm/gems/ruby-2.7.3/gems/nokogumbo-2.0.4/lib/nokogumbo/html5.rb:13: warning: already initialized constant Nokogiri::HTML5::HTML_NAMESPACE`

Could be fixed by these steps:

  • run bundle update nokogumbo - this will update nokogumbo to v 1.2.5 and maybe also update nokogiri in Gemfile.lock
  • Remove older versions of nokogumbo and nokogiri from Gemfile.lock(optional)
  • Check if app running okay
  • Commit and make PR to see if tests are passing

Refer to: sparklemotion/nokogiri#2205

7malikk commented

@cesswairimu can i give this a go?

cesswairimu commented

Go ahead @7malikk, lets leave #11529 for another contributor. thanks

7malikk commented

Go ahead @7malikk, let's leave #11529 for another contributor. thanks

@cesswairimu I just completed #11529 I can leave this one for another contributor

cesswairimu commented

cool 👍 thanks

  • ❤️1
Ibom99 commented

@cesswairimu Can I work on this fix?

victory-lydia commented

@cesswairimu Please can I work on this issue

cesswairimu commented

@Ibom99 , you can go ahead, @victory-lydia I am still working on the warnings, I will ping you if I create a similar one. thanks

Ibom99 commented

Thank you @cesswairimu i’ll get on it!

victory-lydia commented

Thanks @cesswairimu will be waiting

Jennifer-tech commented

Hi @cesswairimu please can I get an issue to work on too

  • 👍1