Log file breaks production builds
Opened this issue · 3 comments
Commit 399e5d1 is breaking our builds because it requires the process to have write access to the directory where the binary is executed (which in our case is an init script).
Could you either use the built-in log
package (or log/syslog
) or make the path to the log file configurable so we can put it in /var/log
?
@technosophos , you can disable logging by setting messaging.SetLogging(false) or configure the path of the log file in pubnub.go, (by setting the value of logfileName https://github.com/pubnub/go/blob/master/messaging/pubnub.go#L94). As of now logfileName is not exposed.
Please do let us know if either approach resolves the issue.
For now, we'll just set logging to false.
I like the way that Go's core "net/http".Server.ErrorLog works
. I'd hope that that is the sort of model you move toward in the future.
@technosophos , thanks for the suggestion. We will look into it.