puiterwijk/flask-oidc

Unable to pip install from pull request

ecederstrand opened this issue · 2 comments

ecederstrand commented

I have a need for #144 which has not yet been merged. However, pip fails to install from GitHub due to the git submodule:

$ pip install git+https://github.com/puiterwijk/flask-oidc.git@refs/pull/144/head
[...]
  Running command git fetch -q https://github.com/puiterwijk/flask-oidc.git refs/pull/144/head
  Resolved https://github.com/puiterwijk/flask-oidc.git to commit ba139d6495267fedf063de564557b7fea734a589
  Running command git submodule update --init --recursive -q
  fatal: unable to connect to github.com:
  github.com[0: 140.82.121.3]: errno=Operation timed out

  fatal: clone of 'git://github.com/mitsuhiko/flask-sphinx-themes.git' into submodule path '/private/var/folders/mf/kmzzbqxd5_s__5pfbdwzyjl80000gn/T/pip-req-build-tqhtjiiy/docs/_themes' failed
  Failed to clone 'docs/_themes' a second time, aborting

pip itself doesn't support skipping submodules. See pypa/pip#6374

It would be really nice to be able to install from GitHub. I see some possible solutions:

  • Move the documentation and submodule to a separate docs branch
  • Remove the submodule and let docs/Makefile clone the theme repo before building documentation
ecederstrand commented

Fixed in gerwout#1 which depends on #144 being merged.