Refactor `DumpType` to use configuration, not database
maxkadel opened this issue · 1 comments
maxkadel commented
What maintenance needs to be done?
Refactor DumpType to use only configuration, not database tables.
Level of urgency
- High
- Moderate
- Low
Why is this maintenance needed?
- This class is mostly used in categorizing dumps, and retrieving them. The
DumpTypetable is only 7 lines long and never changes, which means it behaves more like configuration, - We are seeing errors in using the database table, including in the SQS Poller (see Princeton Ansible PR for changes to Postgres config to try to fix this), and with 15 minute database queries against this table (See Bibdata issue)
Acceptance criteria
- The code does not try to retrieve data from the DumpType table in Postgres
- New and old events still have the correct "Dump Type" in the UI
- Tests continue to pass
- Make rollback as easy as possible (aka, don't immediately drop the table on first deploy without a plan for if something goes wrong)