Update awsx to use docker-build
mjeffryes opened this issue · 5 comments
docker-build is build is now the recommended way to build docker images, so we need to update the AWSX components to use it.
I'd like to propose a different option here. Instead of adding the different docker resources, why don't we add a function/resource method to create the provider/auth data instead?
The existing Image resource is mostly just configuring auth: https://github.com/pulumi/pulumi-awsx/blob/44d871d77778c9c5cad7b0e421a37b4153692bc9/awsx/ecr/image.ts
Yes I think this is a great idea. This gives users much more composable blocks to build from.
Option 1: Include the credentials as an output of the registry resource in awsx - an object containing registry, username & password properties. These must be marked as secrets.
Option 2: Create an invoke which returns the same properties. This could live in either aws or awsx.
Perhaps we do both?
This sounds like a great idea!
@flostadler to clarify, we aren't adding any new resources only changing the internals of what's currently available. The legacy docker provider is showing its age, and it would be good to prevent issues like e.g. pulumi/pulumi-docker#967 (comment) from biting the user.
I agree that auth helpers would also be a great cohesive addition.
Any ideas on when this make it out into production? We'd like to be able to use docker this way instead of having to make config changes