pulumi/pulumi-digitalocean

Add Postgres database attributes

Closed this issue · 4 comments

linuxluigi commented

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Add a option to configure work_mem & shared_buffers_percentage for a Postgres cluster. Looks like the Terraform provider already support all the attributes from the DO API. It would be great to have more options for the Postgres cluster configuration.

If somebody tells where the changes are needed, I'm happy to contribute 🙂

Affected area/feature

Properly Terraform bridge

guineveresaenger commented

Hi @linuxluigi - thank you for opening this issue.

Can you tell us a bit more about which Pulumi resource you'd like to be enhanced? I assume you're talking bout digitalocean.DatabaseCluster but if not, a resource token would be helpful here!

I checked with the upstream documentation for a DO database cluster, postgres flavor, and there's no support for work_mem or shared_buffers_percentage yet. The vendor dependencies you've linked don't necessarily translate into full support on the resource.

Since this provider uses the TF provider as an upstream dependency, you'd see new features like this percolate into our provider shortly. You may want to file a feature request upstream as well.

  • ❤️1
linuxluigi commented

Hey @guineveresaenger,
thanks for answering.

I guess you are right, the resource would be digitalocean.DatabaseCluster.

For the Terraform provider I also created the same feature requests, as you suggests.

linuxluigi commented

The PR digitalocean/terraform-provider-digitalocean#1139 which added the PostgreSQL configurations is merged and a new terraform release was build yesterday.

What need to be done to add this to the Pulumi provider?