pupil-labs/hmd-eyes

PupilTools FloatFromDictionary does not use key parameter

mikkeyboi opened this issue · 2 comments

See here

	public static float FloatFromDictionary(Dictionary<string,object> source, string key)
	{
		object value_o;
		source.TryGetValue ("confidence", out value_o);
		return (float)(double)value_o;
	}

It's almost certainly true that "confidence" needs to be replaced by key. I'm surprised this hasn't come up before because it seems to affect timestamps in recordings here.

Sorry, it was me but I accidentally posted this under my colleague's account.

@cboulay Thank you for the input! Would you mind making a PR and we will merge it!