Possible false positives re: deftheme

[riscy]

Hello! I believe in certain cases false positives are being raised with the use of deftheme regarding the package prefix.

Here's a minimal file (that would be named riscy-theme.el):

;;; riscy-theme.el --- Riscy theme

;; Author: riscy
;; Version: 1.0
;; URL: https://github.com/riscy
;; Package-Requires: ((emacs "26.1"))

;;; Commentary:

;; ...

;;; Code:

(deftheme riscy "...")

(custom-theme-set-faces 'riscy nil)

(provide-theme 'riscy)
(provide 'riscy-theme)
;;; riscy-theme.el ends here

This file raises the following package-lint (using version 20210320.438):

14:0: error: "riscy" doesn't start with package's prefix "riscy-theme".

but I believe, per convention, this is exactly what the theme should be called in this case. This cropped up in a recent MELPA PR here: melpa/melpa#7520 (comment)

[purcell]

I believe I have done this now, thanks @riscy. Let me know if you find any issues.

[Deleted user]

Confirming that your latest changes fixed the error described in this issue. Thanks @purcell!

[purcell]

Thanks @rgrmrts 🤜🤛