purduesigbots/pros-cli2

Uploading with some third-party COM ports fails

edjubuh opened this issue · 1 comments

Expected Behavior:

Be able to upload projects no matter what COM ports Windows thinks exist.

Actual Behavior:

Some devices do not report all the information we query when checking if a COM port is a Cortex microcontroller. One example is the Arduino Uno.

Steps to reproduce:

Plug in a device like an Arduino Uno and attempt to upload.

System information:

Operating System: Windows, but likely affects all platforms

PROS Version: 2.5.1

Additional Information

The issue is with https://github.com/purduesigbots/pros-cli/blob/master/prosflasher/ports.py#L16 - just need to make it type check

Screenshots/Output Dumps/Stack Traces

image
image
image

Although we do have a fix inbound (#37), the workaround for this issue in the meantime is to simply unplug the other COM device(s).