How do I `preventDefault` inside `onKeyUp`?

Question

How do I `preventDefault` inside `onKeyUp`?

unclechu opened this issue 8 years ago · 6 comments

I don't have Event in this handler to do so.

Answer 1 · 2018-02-24T16:35:52.000Z

This is perhaps not a great solution, but would it work to coerce KeyboardEvent to Event? Maybe having a function to do this in the library would be handy, or maybe the events defined in the library can be updated in a way to accommodate this.

Answer 2 · 2018-02-24T16:38:21.000Z

@ethul Coercing KeyboardEvent to Event is unsafe, because, we can just create an record that satisfies type of KeyboardEvent (that is simple unwrapped record), and by this coercing we can get runtime fails.

Answer 3 · 2018-02-24T16:40:18.000Z

Agreed this would be unsafe. Does it temporarily solve your issue? Maybe reworking the way the events are represented would be worth looking further into. I am open to ideas on this.

Answer 4 · 2018-02-24T16:41:54.000Z

I think type of KeyboardEvent must change, at least, with minimal breaking changes, an event key could be added to the KeyboardEvent type that would have a reference to Event (but in this case, we have to construct new object).

Answer 5 · 2018-02-24T16:42:32.000Z

Does it temporarily solve your issue?

I haven't tried but it probably will solve it.

Answer 6 · 2018-02-24T16:46:59.000Z

I think the best way would be to make some newtypes for events and to add some type class like ReactEvent that would have preventDefault and stopPropagation to implement. And KeyboardEvent shouldn't be just a record with simple data, at least it must have some field with FFI type like Event.