purescript-contrib/purescript-react

document `npm install`

alicebob opened this issue · 3 comments

alicebob commented

When using this in a browser you need to run npm install react react-dom with specific react versions. Also pulp bundle isn't good enough anymore and you will need to use pulp browserify.
I did not find this documented anywhere (coming from the Thermite repo). It would be incredible helpful if that was mentioned in the README here and/or at Thermite.

See also
https://stackoverflow.com/questions/42763558/integrating-react-components-with-pux-where-does-require-come-from
https://stackoverflow.com/questions/43337332/electron-purescript-thermite

ethul commented

I agree that it would be helpful to mention that this module depends on the react library. Having an example of using NPM as one option to satisfy the dependency would be a nice addition to the README.

Thanks for bringing this up.

alicebob commented

🎊 thanks!

ethul commented