purescript-contrib/purescript-react

Remove createFactory?

safareli opened this issue · 3 comments

safareli commented

Is there a point of having createFactory? it just call's createElement

https://github.com/facebook/react/blob/master/packages/react/src/ReactElement.js#L260-L273

safareli commented

based on current definition of createFactory in react, we can define it here as:
createFactory cls props = createElement cls props mempty

and as it has no advantages we can just remove it.

paulyoung commented

This came up in #128, and I thought it was removed in #129.

safareli commented

Ah I was looking at old version of this lib :d