purescript-contrib/purescript-string-parsers

No more `Char`

justinwoo opened this issue · 3 comments

justinwoo commented

I really don't think Char helps here in any way, since that's not even a thing in JS and now we have some ambiguity between CodeUnits and CodePoints. Can we be rid of this and properly use String types wherever we have Strings?

anttih commented

I just noticed while glancing over the implementation that CodePoints uses charAt in anyChar which deals with code units instead of code points. So either it should return a CodePoint or a String as you suggested.

  • 👍1
hdgarrood commented

I'd prefer to make a decision on purescript/purescript#3662 first.

github-actions commented

This issue is stale because it has been open for 60 days with no activity. Remove the stale label or comment to keep this issue open. Otherwise, this issue will be closed in 14 days.