Highlighting explicit types in multiline import

Question

Highlighting explicit types in multiline import

unclechu opened this issue 8 years ago · 5 comments

Answer 1 · 2018-02-17T23:34:38.000Z

as keyword also have this issue:

Answer 2 · 2018-02-21T22:25:18.000Z

Also if I just rename import to module it goes okay (maybe some parts of regex from module could be taken to fix import regex).

Answer 3 · 2018-03-11T12:01:37.000Z

Please try the new version. It now consistently highlights classes, kinds, and functions within import and module syntax groups.

Answer 4 · 2018-03-11T13:56:36.000Z

@coot now I have both this issue and new one, all module names have similar color as import/module keyword.

So, I guess this issue supposed to be reopened.

Answer 5 · 2018-03-11T17:29:59.000Z

The bottom screenshare is how it is supposed to look like. You might differentiate the import and module by having different colours for purscriptImportKeyword (by default linked to purescriptKeyword) and purescriptModuleName (by default linked to Include) highlight classes.

The top one looks different here, ReactClass and other that start with an uppercase letter have purescritpConstructor syntax group and other have purescriptIdentifier. It's a bit different when they are in the same line (which should be fixed), but still the default highlighting is consistent.